Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: plotly/plotly.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: wayne-o/plotly.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 6 files changed
  • 1 contributor

Commits on Jul 19, 2018

  1. Changes to make redrawObjs work by convention

    Wayne Douglas
    Wayne Douglas committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    23fdd70 View commit details
    Browse the repository at this point in the history

  2. remove trailing spaces

    Wayne Douglas
    Wayne Douglas committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    976bffc View commit details
    Browse the repository at this point in the history

  3. syntax fixes

    Wayne Douglas
    Wayne Douglas committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    bc34411 View commit details
    Browse the repository at this point in the history

  4. syntax fixes

    Wayne Douglas
    Wayne Douglas committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    3fc2da7 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2018

  1. Updates as per @etpinard comments 

    [NOTE] - I have added a  updateOnPanShortCircuit property to handle the images shortcicuit but I am not sure if this is unecessary noise?
    Wayne Douglas
    Wayne Douglas committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    711c705 View commit details
    Browse the repository at this point in the history

  2. remove updateOnPanShortCircuit as i think it's failing some tests

    Wayne Douglas
    Wayne Douglas committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    a0ebdb4 View commit details
    Browse the repository at this point in the history

  3. don't need to have the drawModule.draw as it exports a function - jus… 

    …t use drawModule
    Wayne Douglas
    Wayne Douglas committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    931e253 View commit details
    Browse the repository at this point in the history

  4. Adding back updateOnPanShortCircuit and hopefuly fixing the tests

    Wayne Douglas
    Wayne Douglas committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    1479e9f View commit details
    Browse the repository at this point in the history
Loading