Skip to content

MONIT-12724 Fix for Proxy with traceSamplingRate unset and traceSamplingDuration effective will generate unexpected result#368

Merged
vikramraman merged 4 commits into
masterfrom
akodali/MONIT-12724-handle-samplerate
Feb 27, 2019
Merged

MONIT-12724 Fix for Proxy with traceSamplingRate unset and traceSamplingDuration effective will generate unexpected result#368
vikramraman merged 4 commits into
masterfrom
akodali/MONIT-12724-handle-samplerate

Conversation

@akodali18

@akodali18 akodali18 commented Feb 27, 2019

Copy link
Copy Markdown
Contributor

yet to test.

@akodali18 akodali18 changed the title Handle rateSampler for rate = 1 MONIT-12724 Fix for Proxy with traceSamplingRate unset and traceSamplingDuration effective will generate unexpected result Feb 27, 2019
vikramraman
vikramraman reviewed Feb 27, 2019
View reviewed changes
Comment thread pkg/etc/wavefront/wavefront-proxy/wavefront.conf.default Outdated
vikramraman
vikramraman reviewed Feb 27, 2019
View reviewed changes
Comment thread pkg/etc/wavefront/wavefront-proxy/wavefront.conf.default Outdated
@vikramraman vikramraman merged commit 0c2abd7 into master Feb 27, 2019
akodali18 added a commit that referenced this pull request Feb 27, 2019
@akodali18
MONIT-12724 Fix for Proxy with traceSamplingRate unset and traceSampl…
9fb6f98 
…ingDuration effective will generate unexpected result (#368)

* Handle rateSampler for rate = 1
* Adding sampling params to default conf file.

(cherry picked from commit 0c2abd7)
@basilisk487 basilisk487 deleted the akodali/MONIT-12724-handle-samplerate branch April 4, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@vikramraman vikramraman vikramraman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akodali18 @vikramraman