Skip to content

[Conversation] workspaces and intents CRUD operations - #632

Closed
boazdavid wants to merge 548 commits into
watson-developer-cloud:developfrom
JoshSharpe:master
Closed

[Conversation] workspaces and intents CRUD operations#632
boazdavid wants to merge 548 commits into
watson-developer-cloud:developfrom
JoshSharpe:master

Conversation

@boazdavid

Copy link
Copy Markdown
Contributor

🆕
add support for new conversation api.
create/ update/ delete/ get/ list of: workspace/intent
includes javadoc, and unit tests.
code style was checked.

these functions of the api were not implemented:
example/ counterExamples

jeffpk62 and others added 30 commits February 19, 2017 13:23
Address other small JavaDoc issues across build
Enable customization for Speech to Test WebSocket recognition requests
Fix and expand constructors for Speech to Text Word object
…loud/issue-587

Add onListening() and onInactivityTimeout() to Speech callback
📝 Update CHANGELOG.md for new Tradeoff Analytics features
1) Add code coverage to gradle
2) Add the ability to aggregate all the test results in each sub
project to 1 report
…loud/fix-stt

[speech-to-text] Fix inactivity_timeout bug and add integration test to avoid future problems.
@codecov-io

codecov-io commented Apr 2, 2017

Copy link
Copy Markdown

Codecov Report

Merging #632 into develop will decrease coverage by 12.27%.
The diff coverage is 56.41%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop     #632       +/-   ##
==============================================
- Coverage      59.48%   47.21%   -12.28%     
+ Complexity      1617     1255      -362     
==============================================
  Files            363      384       +21     
  Lines           7116     7451      +335     
  Branches         431      455       +24     
==============================================
- Hits            4233     3518      -715     
- Misses          2555     3619     +1064     
+ Partials         328      314       -14
Impacted Files Coverage Δ Complexity Δ
.../developer_cloud/conversation/v1/model/Entity.java 35.71% <ø> (ø) 1 <0> (ø) ⬇️
...ation/v1/model/workspace/nodes/DialogNodeGoTo.java 0% <0%> (ø) 0 <0> (?)
...ion/v1/model/workspace/nodes/DialogNodeOutput.java 0% <0%> (ø) 0 <0> (?)
...per_cloud/conversation/v1/model/JsonConstants.java 0% <0%> (ø) 0 <0> (?)
...rsation/v1/model/workspace/entity/CreateValue.java 10% <10%> (ø) 1 <1> (?)
...eloper_cloud/conversation/v1/model/Pagination.java 10% <10%> (ø) 1 <1> (?)
...ion/v1/model/workspace/intent/ExampleResponse.java 100% <100%> (ø) 3 <3> (?)
...tion/v1/model/workspace/intent/IntentResponse.java 100% <100%> (ø) 3 <3> (?)
...conversation/v1/model/workspace/intent/Intent.java 100% <100%> (ø) 3 <3> (?)
...oud/conversation/v1/model/workspace/Workspace.java 100% <100%> (ø) 6 <6> (?)
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0aac33...cbfa336. Read the comment docs.

* @param metadata
* The metadata for the dialog node.
*/
public void setMetadata(Object metadata) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object (?) I think it should be Map<String, Object>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Conversation API it is an object. https://www.ibm.com/watson/developercloud/conversation/api/v1/?curl#create_workspace

metadata
object
Any metadata that is required by the workspace.

I did not find an example of that object.
Do you think we should represent all JSON objects as Map<String, Object>?

@germanattanasio

Copy link
Copy Markdown
Contributor

@boazdavid, I'm looking at merging #646 instead of this. The code in that branch was autogenerated and it's aligned to the direction we are targeting with the SDK.
I will talk to @mkistler to make sure we have the tests and Javadoc you wrote here.
Sorry for the late notice.

@germanattanasio

Copy link
Copy Markdown
Contributor

We are going to merge the code from @mkistler later today. I'm going to close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants