Conversation
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
=========================================
Coverage ? 55.99%
Complexity ? 1301
=========================================
Files ? 320
Lines ? 6356
Branches ? 417
=========================================
Hits ? 3559
Misses ? 2477
Partials ? 320
Continue to review full report at Codecov.
|
jeffpk62
approved these changes
Feb 21, 2017
jeffpk62
left a comment
jeffpk62
left a comment
Contributor
There was a problem hiding this comment.
Looks good with one pedantic comment: Would the code maybe be clearer if the inactivityTimeout Boolean were renamed to something like inactivityTimeoutOccurred or something like that to avoid confusion with the option?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecognizeOptionsclass.inactivity_timeout