fix(nlc): add a deprecation message - #1185
Merged
Merged
Conversation
|
|
kevinkowa
requested changes
Aug 17, 2021
kevinkowa
left a comment
kevinkowa
left a comment
Contributor
There was a problem hiding this comment.
Looks good. We should also add something along the lines of
/**
* @deprecated On 1 December 2021, Personality Insights will no longer be available.
* Consider migrating to Watson Natural Language Understanding.
* For more information, see Personality Insights Deprecation
* (https://github.com/watson-developer-cloud/java-sdk/tree/master#personality-insights-deprecation).
*/
@Deprecated
public class PersonalityInsights extends BaseService {
This is what happens on personality insights, we just need to override the message
Contributor
Author
Thank you! I will update it. |
watson-github-bot
pushed a commit
that referenced
this pull request
Sep 1, 2021
## [9.2.2](v9.2.1...v9.2.2) (2021-09-01) ### Bug Fixes * **nlc:** add a deprecation message ([#1185](#1185)) ([b460cdd](b460cdd))
Contributor
|
🎉 This PR is included in version 9.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a deprecation message