Skip to content

WAR-2053: The data stored in test data response is getting deleted when we are calling the connect keyword#458

Merged
bjrr merged 2 commits into
developfrom
feature/WAR-2053
Jan 15, 2019
Merged

WAR-2053: The data stored in test data response is getting deleted when we are calling the connect keyword#458
bjrr merged 2 commits into
developfrom
feature/WAR-2053

Conversation

@apathapa-warrior

Copy link
Copy Markdown
Contributor

Attached logs in jira ticket.

@ghost

ghost commented Dec 6, 2018

Copy link
Copy Markdown

Black Duck Security Report

Merging #458 into develop will not change security risk.

Added Components

Clean: 1

Removed Components

Clean: 1

Click here to see full report

@apathapa-warrior apathapa-warrior changed the title Feature/war 2053(The data stored in data repository is getting deleted when we are calling the connect keyword) Feature/war 2053(The data stored in test data response is getting deleted when we are calling the connect keyword.) Dec 6, 2018
Comment thread wftests/warrior_tests/data/cli_resp_Data.xml Outdated

@santhosh-warrior santhosh-warrior left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move all the tests under FNC specific testing

@apathapa-warrior

Copy link
Copy Markdown
Contributor Author

Added Test case in warrior_fnc_tests repo.

@sanikakulkarni sanikakulkarni changed the title Feature/war 2053(The data stored in test data response is getting deleted when we are calling the connect keyword.) WAR-2053: The data stored in test data response is getting deleted when we are calling the connect keyword Jan 9, 2019
from Framework.Utils.data_Utils import get_object_from_datarepository
from WarriorCore.Classes.warmock_class import mocked
from timeit import itertools
from Framework.Utils.config_Utils import data_repository

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure what resp_pat_key has to do with keeping the data_response in the data_repository. Can you please explain the changes made in this pull request?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sanikakulkarni,

Attached the mail thread in Jira ticket and forwarded the same mail thread to you as well.
This commit was fixed by Reshma and user already tested it and it is working fine.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @apathapa-warrior,

I have the email with me and I understand the request that generated this ticket. I am still unsure as to how the resp_pat_key relates to the changes requested in the email. Can you please explain the changes made here and how to test those changes?

Thanks,
Sanika

@sanikakulkarni
sanikakulkarni self-requested a review January 9, 2019 22:17

@sanikakulkarni sanikakulkarni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need clarification about changes done in the PR

@sanikakulkarni

Copy link
Copy Markdown
Contributor

Please create testcases to test this change. Please refer to the JIRA ticket for further information

@bjrr
bjrr merged commit 00c4708 into develop Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants