WAR:1725, WAR-1734(katana-apps-demo) - verify is not working properly in iterative parallel#386
Closed
venkat1077 wants to merge 3 commits into
Closed
WAR:1725, WAR-1734(katana-apps-demo) - verify is not working properly in iterative parallel#386venkat1077 wants to merge 3 commits into
venkat1077 wants to merge 3 commits into
Conversation
Black Duck Security ReportMerging #386 into katana-apps-demo will not change security risk. Added ComponentsClean: 1 Removed ComponentsMedium Risk: 1 |
Contributor
|
Removing myself as main part of the logic is in td iteration |
kaheichan
removed their request for review
February 23, 2018 16:15
venkat1077
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for develop branch : #375
This issue(WAR-1725) not just happens for iterative parallel execution, it happens in all cases when the list iteration is used. Both WAR-1725 and WAR-1734 were working well till 3.6.0 and were introduced by #313 in 3.7.0.
Solution:
Fix explanation:
We use location/index to rearrange the command_list that was iterated using '+' for per_td_block(with yes) iteration. Here I have added a similar logic for list iteration so that the commands derived from list will be treated same like the commands derived using '+'.
Note: WAR-1734 is also resolved since the PR which introduced it, is completely removed here.
Regression logs and tests instructions are in WAR-1725