Skip to content

WAR:1583 - Incorrect Results printed on Console window for iterative Parallel TC#335

Merged
bjrr merged 3 commits into
developfrom
bugfix/WAR-1583
Jan 9, 2018
Merged

WAR:1583 - Incorrect Results printed on Console window for iterative Parallel TC#335
bjrr merged 3 commits into
developfrom
bugfix/WAR-1583

Conversation

@venkat1077

@venkat1077 venkat1077 commented Dec 27, 2017

Copy link
Copy Markdown
Contributor

Issue - Duplicate entries in the execution summary when executing 'iterative_parallel' suite.
Reason - Same junit object is being added multiple times to the multiprocessing queue during 'iterative_parallel' suite execution.
Fix - junit_object/python_process is same for all the cases executed in the same system for 'iterative_parallel' suite execution so do not append junit object into queue for all the cases(just add once). Code changes are in 5a83b8c, rest are pylint fixes.

How to test - Run any suite with exectype as 'ITERATIVE_PARALLEL' with more than one system in a data_file(test use-case and regression results are in the jira ticket).

@venkat1077 venkat1077 added the bug label Dec 27, 2017
@venkat1077 venkat1077 self-assigned this Dec 27, 2017
@brettleehari

brettleehari commented Jan 3, 2018

Copy link
Copy Markdown
Contributor

Only Ka's review suffice.

@kaheichan

kaheichan commented Jan 5, 2018

Copy link
Copy Markdown
Contributor

Hi @venkat1077
I am still seeing duplicate TC result from the Travis log for this ticket
https://travis-ci.org/warriorframework/warriorframework/jobs/322152490 (scroll to the end)
is this the expected behavior?

@venkat1077

venkat1077 commented Jan 8, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@kaheichan
I'm afraid that this issue is bigger than what I actually thought. I fixed the issue of duplicate entries in results summary when executing a single Iterative_Parallel suite - this works, no more duplicate entries found.

After looking at the shared travis logs, I found that this occurs for normal parallel executions too when running more than one parallel execution units together.

Use-case: Project(sequential suites) with two suites and the exec_type as "parallel_testcases" for both suites.
Potential reason for the Issue - Same junit object is being used to accumulate the status of all the suites.

@kaheichan

kaheichan commented Jan 8, 2018

Copy link
Copy Markdown
Contributor

Hi @venkat1077
I discussed with @bjrr that we should keep the scope of this ticket and please raise a new ticket for the issue you found
For this PR, I created a small manual test attached in the internal ticket and verified that the summary is getting generated without duplicate entry

@venkat1077

venkat1077 commented Jan 9, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks @kaheichan @bjrr
Created WAR-1694 for the above mentioned issue.

@bjrr bjrr merged commit f2718d9 into develop Jan 9, 2018
@bjrr bjrr added this to the Warrior-3.7.0 milestone Jan 12, 2018
@venkat1077 venkat1077 deleted the bugfix/WAR-1583 branch February 6, 2018 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjrr bjrr Awaiting requested review from bjrr
1 more reviewer
@kaheichan kaheichan kaheichan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@venkat1077 venkat1077

Labels

bug

Projects

None yet

Milestone

Warrior-3.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@venkat1077 @brettleehari @kaheichan @bjrr