Skip to content

WAR-1548 Refactor selenium keyword to support both selenium 2.0 and 3.0 with different version of chrome/firefox#334

Merged
bjrr merged 55 commits into
developfrom
WAR-1548-reverted-724
Jan 9, 2018
Merged

WAR-1548 Refactor selenium keyword to support both selenium 2.0 and 3.0 with different version of chrome/firefox#334
bjrr merged 55 commits into
developfrom
WAR-1548-reverted-724

Conversation

@kaheichan

@kaheichan kaheichan commented Dec 20, 2017

Copy link
Copy Markdown
Contributor

Due to #62 and #133 changes which cause instability to the platform as the code logic is flawed
This PR revert those changes and will provide a stable release

This ticket also includes changes for WAR-1591
and necessary support for WAR-1074 to run correctly

With firefox version 47 and above, a geckodriver is needed in the local sys env path
https://github.com/mozilla/geckodriver/releases
Chrome needs chromedriver
https://sites.google.com/a/chromium.org/chromedriver/downloads

if geckodriver is needed, then selenium version needs to be 3.5 or above
https://github.com/mozilla/geckodriver#selenium
which means for Firefox 47 and above, warrior needs both geckodriver and selenium >= 3.5 to run
Chrome isn't affected

For geckodriver launched firefox
currently found that browser.capabilities dict has "browserVersion" instead of "version"
needs to handle this kind of key changes in warriorframework

Test files are updated in internal repo

Code is ready to be reviewed

This reverts commit 8b58a73, reversing
changes made to 0c67756.
…3support"

This reverts commit 84265e0, reversing
changes made to d16e336.
@kaheichan kaheichan self-assigned this Dec 20, 2017
@bjrr bjrr requested review from bjrr and sanikakulkarni and removed request for brettleehari January 4, 2018 23:03
sanikakulkarni
sanikakulkarni previously approved these changes Jan 9, 2018
@bjrr bjrr merged commit 14d3e90 into develop Jan 9, 2018
@bjrr bjrr added this to the Warrior-3.7.0 milestone Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants