WAR-1548 Refactor selenium keyword to support both selenium 2.0 and 3.0 with different version of chrome/firefox#334
Merged
Merged
Conversation
sanikakulkarni
previously approved these changes
Jan 9, 2018
sanikakulkarni
approved these changes
Jan 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to #62 and #133 changes which cause instability to the platform as the code logic is flawed
This PR revert those changes and will provide a stable release
This ticket also includes changes for WAR-1591
and necessary support for WAR-1074 to run correctly
With firefox version 47 and above, a geckodriver is needed in the local sys env path
https://github.com/mozilla/geckodriver/releases
Chrome needs chromedriver
https://sites.google.com/a/chromium.org/chromedriver/downloads
if geckodriver is needed, then selenium version needs to be 3.5 or above
https://github.com/mozilla/geckodriver#selenium
which means for Firefox 47 and above, warrior needs both geckodriver and selenium >= 3.5 to run
Chrome isn't affected
For geckodriver launched firefox
currently found that browser.capabilities dict has "browserVersion" instead of "version"
needs to handle this kind of key changes in warriorframework
Test files are updated in internal repo
Code is ready to be reviewed