1548: Selenium: open browser code does not account for default values of arguments and 1591: Selenium fix for togther as these tickets are interdependent#317
Conversation
UPdated proxy_port instead of gecko_path
UPdated proxy_port instead of gecko_path
navvrnd
left a comment
navvrnd
left a comment
There was a problem hiding this comment.
Add negative cases with binary, gecko_path with null, False or None values and attach the logs in the ticket.
| ff_profile = self.browser_object.\ | ||
| set_firefoxprofile(proxy_ip, proxy_port) | ||
| if binary != "" and gecko_path != "": | ||
| if browser_details["gecko_path"] not in [None, False] and \ |
There was a problem hiding this comment.
check if gecko_path is there in browser_details before checking its value
| firefox_profile=profile_dir, | ||
| executable_path=gecko_path) | ||
| else: | ||
| except: |
There was a problem hiding this comment.
why this nested try catch? why can't this be handled in the outer try/except? Please handle the specific exceptions expected.
|
Code not in ready-to-review state, will add assignee once it is ready |
|
A New PR #333 has been created to fit the scope of all related ticket |
| firefox_profile=profile_dir, | ||
| executable_path=gecko_path) | ||
| else: | ||
| except: |
There was a problem hiding this comment.
The try except block ignore the error and force a Firefox browser to spawn
without logging the potential error
| "name", | ||
| remote = data_Utils.getSystemData(self.datafile, system_name, "remote") | ||
| if binary is None: | ||
| binary = data_Utils.getSystemData(self.datafile, system_name, "binary") |
There was a problem hiding this comment.
binary, gecko_path. proxy_ip and proxy_port aren't in system
It's inside browser level
3 participants
Addressed, 1548 and 1591 together as they are interdependent.