WAR-1445: Iteration by test block not working for list#313
Merged
Conversation
venkat1077
approved these changes
Nov 27, 2017
venkat1077
left a comment
venkat1077
left a comment
Contributor
There was a problem hiding this comment.
Code looks good. Tested the fix and it works.
satyakrish
suggested changes
Dec 7, 2017
satyakrish
left a comment
satyakrish
left a comment
Contributor
There was a problem hiding this comment.
added comments to jira ticket as it was a design change request
satyakrish
suggested changes
Dec 22, 2017
satyakrish
left a comment
satyakrish
left a comment
Contributor
There was a problem hiding this comment.
code looks good except for the one comment, pls address it so that i can approve ad merge
| # iteration patterns in the command and get a updated | ||
| if isinstance(cmd, str) and '+' not in cmd: | ||
| # check if list exists in cmd | ||
| td_obj = TestData() |
Contributor
There was a problem hiding this comment.
why intialize a new TestData object here, please use self.list_substitution_precheck
Contributor
Author
There was a problem hiding this comment.
@satyakrish
list_substitution_precheck is in TestData Class and I am using it in TestDataIterations Class, So creating a new object for it.
satyakrish
approved these changes
Jan 8, 2018
This was referenced Feb 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If list is given in per_td_block, then it should be iterated.
Currently all values in list will be printed next to next.
Test is added to warrior_fnc_test