Skip to content

Fix cloning of curve object #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BruceSherwood merged 1 commit into from
Mar 15, 2021
Merged

Fix cloning of curve object #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ForInstalledPython/glow.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion GlowScriptOffline/glowscript_libraries/glow.3.0.min.js
View file
Open in desktop

Large diffs are not rendered by default.

Binary file modified GlowScriptOffline3.0.zip
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions ide/ide.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,8 +1383,8 @@ $(function () {
ev.preventDefault()
// If I don't pass anything for features, I get a new tab instead
var features = "titlebar=yes,location=yes,resizable=yes,scrollbars=yes,status=yes,toolbar=yes"
window.open("/#/", "GlowScriptRun", features, true)
window.open(run_link, "GlowScriptRun", features, true)
window.open("/#/", "GlowScriptRun", features)
window.open(run_link, "GlowScriptRun", features)
}
}

Expand Down
2 changes: 1 addition & 1 deletion lib/glow/primitives.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@
var oldargs = {canvas:cvs, pos:pos, __radius:this.__radius,
__shininess:this.__shininess, __emissive:this.__emissive,
visible:true, __pickable:this.__pickable}
ret = new curve(oldargs)
ret = curve(oldargs)
} else if (this instanceof helix) {
var oldargs = {canvas:cvs, __thickness:this.__thickness, __coils:this.__coils,
__shininess:this.__shininess, __emissive:this.__emissive,
Expand Down
2 changes: 1 addition & 1 deletion package/glow.3.0.min.js
View file
Open in desktop

Large diffs are not rendered by default.