Repository navigation
Conversation
Comment on lines
+2
to
+3
| private final String name; | ||
| private final int speed; |
There was a problem hiding this comment.
Так как обе переменные являются final, то можно не делать их приватными и писать геттеры, а просто сделать публичными - это безопасно, т.к. доступ к этим переменным будет только на чтение за счёт final
| } | ||
|
|
||
| public static int speedChecking() { | ||
| Scanner scanner = new Scanner(System.in); |
There was a problem hiding this comment.
Сканнер лучше создать один раз на уровне класса и переиспользовать, т.к. создание этого объекта - тяжёлая операция
| cars[i]=new Car(carName, carSpeed); | ||
|
|
||
| } | ||
| race.bestCar(cars); |
There was a problem hiding this comment.
Можно сразу при чтении данных выявлять нового победителя, тогда не придётся хранить весь массив машин в программе и тогда программа будет требовать меньше памяти для её выполнения
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 sprint