Fix oneof and enum parity issues for minimal proto test#61
Fix oneof and enum parity issues for minimal proto test#61google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change fixes several parity issues in the Java code generator to match
protocoutput, specifically targetingMinimalProtoParityTestandComprehensiveTestNestedMinimalParityTest.Key changes:
MessageFieldGenerator.javato correctly handleoneoffields vs regular fields in terms ofonChanged()placement, builder accessor side effects, and merge logic.MessageFieldGeneratorfor oneof getters and merge calls.EnumFieldGenerator.javavariable naming (tmpRawvsrawValue) to satisfy parity tests.PROTOC.mdwith new findings regarding oneof handling and indentation rules.These changes ensure that the generated Java code for minimal and nested proto files is byte-for-byte identical to the reference implementation.
PR created automatically by Jules for task 13557925690011261410 started by @voidifremoved