Fix parity issues for ComprehensiveTestV3Minimal#52
Fix parity issues for ComprehensiveTestV3Minimal#52google-labs-jules[bot] wants to merge 1 commit into
Conversation
- Revert `CODE_SIZE` suppression of `MemoizedSerializedSize` in `PrimitiveFieldGenerator` and `EnumFieldGenerator` to match `protoc` behavior where this field is generated even if serialization methods are skipped. - Fix Javadoc formatting in `DocComment.java` to use `<pre>` tags for field definitions and `<code>` tags for method signatures, matching inconsistent `protoc` output. - Update `Parser.java` to correctly detect and flag `proto3` `optional` fields as synthetic oneofs. - Ensure `StringFieldGenerator` strictly enforces UTF-8 checks for Proto3. - Add integer-based list accessors (`getValueList`, `addValue`, etc.) to `EnumFieldGenerator` for repeated enums to support unknown values. - Adjust default value formatting in `PrimitiveFieldGenerator` to use literals (e.g., `0F`) for Proto3 defaults.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change addresses multiple parity issues identified by
ComprehensiveTestV3MinimalParityTest. Key fixes include restoringMemoizedSerializedSizegeneration for packed fields regardless of optimization mode, correcting Javadoc HTML tags to matchprotocidiosyncrasies, enforcing strict UTF-8 checks for Proto3 strings, and ensuring proper handling of Proto3optionalfields as synthetic oneofs. Additionally, it implements missing integer-based accessors for repeated enum fields.PR created automatically by Jules for task 13761370985489040208 started by @voidifremoved