Add SMTP_NOAUTH support for unauthenticated SMTP servers#425
Open
mderasse wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new SMTP_NOAUTH configuration option that allows users to disable SMTP authentication when connecting to mail servers that do not require credentials (e.g., IP-whitelisted relays).
Changes:
- Introduce
SMTP_NOAUTHboolean config field with defaultfalse, parsed as boolean from env. - Conditionally omit the nodemailer
authobject whenSMTP_NOAUTHis true. - Document the new env variable in Getting-Started.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/util/config.ts | Adds the SMTP_NOAUTH field and includes it in the boolean-parsing branch of assignConfigValue. |
| server/util/email.ts | Sets the nodemailer transport auth to undefined when SMTP_NOAUTH is enabled. |
| docs/Getting-Started.md | Documents the new SMTP_NOAUTH environment variable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new SMTP_NOAUTH environment variable (boolean, defaults to false) that allows disabling SMTP authentication when connecting to mail servers that don't require credentials, such as those using IP whitelisting. (let me know if you prefer to just check if user and pass are empty and avoid an env variable)
When set to true, the nodemailer transport's auth object is set to undefined, skipping the authentication step entirely.
This avoids connection errors that occur when nodemailer attempts to authenticate against servers that have no auth mechanism configured.