Skip to content

[WIP] Pypes Refactor#273

Open
rlizzo wants to merge 68 commits into
masterfrom
develop-pypes
Open

[WIP] Pypes Refactor#273
rlizzo wants to merge 68 commits into
masterfrom
develop-pypes

Conversation

@rlizzo

@rlizzo rlizzo commented May 2, 2018

Copy link
Copy Markdown
Member

I am creating this PR in order to centralize conversation around the proposed changes to the Pypes Modeule, Jupyter Notebook Integration, and the general package structure layout.

At the time of writing, the develop-pypes branch is composed of #272 #271 #268.

More information to follow.

rlizzo and others added 30 commits April 24, 2018 04:03
This was necessary to do because of character encoding differences in
python 2 and 3. Since we were note defining an explicit encoding, we
were getting odd "non-ascii-character" errors in python 2. See PEP 263
https://www.python.org/dev/peps/pep-0263/ for more info.
This attempts to clarify and optomize the behavior of the pypes module.
The previous method (using exec to import * from a module) is considered
to be extremly sinful and risky. This should achieve the same purpose
while preventing duplicate imports and non-necessary namespace creation.
[WIP] PypeS Refactor & Documentation
Cleanup Package Structure and Import Handling
…upport since the simplenamespace object is not included
@rlizzo

rlizzo commented Jun 29, 2018

Copy link
Copy Markdown
Member Author

@daron1337 this is the PR which needs review. I will fix the conflicts this weekend. Thank you!

@daron1337

Copy link
Copy Markdown
Member

@rlizzo it seems ok to me, ping @lantiga

Comment thread CMakeLists.txt
Comment thread CMakeLists.txt
Comment thread CMakeLists.txt
Comment thread CONTRIBUTING.md
In order to successfully compile and use vmtk, the following software has to be installed in your system:
- [Git](www.git-scm.org) (>= 1.6)
- [Python](www.python.org) (2.7, 3.5+)
- [Python](www.python.org) (3.5+)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 3.7

Comment thread PypeS/pypebatch.py
Comment thread PypeS/pypepad.py Outdated
Comment thread PypeS/pypepad.py
Comment thread SuperBuild.cmake
Comment thread tests/test_vmtkScripts/conftest.py
Comment thread vmtkScripts/__init__.py
Comment thread vmtkinteractive.py
Comment thread PypeS/pype.py Outdated
Comment thread PypeS/pype.py
Comment thread PypeS/pype.py
Comment thread PypeS/pype.py Outdated
@lassoan

lassoan commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

@kayarre what do you think about this PR?

@kayarre

kayarre commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

Thank you @lassoan. I will look at this within this week and dig around.

@lassoan lassoan mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants