Fix not to save app's state on task which is not intended

minjk-bl · minjk-bl · commit 5fee3528f60c · 2023-08-30T13:07:37.000+09:00
diff --git a/visualpython/js/com/component/PopupComponent.js b/visualpython/js/com/component/PopupComponent.js
@@ -342,10 +342,7 @@ define([
             // Toggle operation (minimize)
             $(this.wrapSelector('.vp-popup-toggle')).on('click', function(evt) {
                 evt.stopPropagation();
-                $(that.eventTarget).trigger({
-                    type: 'close_option_page',
-                    component: that
-                });
+                that.hide();
             });
             // Maximize operation
             $(this.wrapSelector('.vp-popup-maximize')).on('click', function(evt) {
@@ -1071,7 +1068,15 @@ define([
         close() {
             vpLog.display(VP_LOG_TYPE.DEVELOP, 'close popup', this);
             this.saveState();
-            this.hide();
+            if (this.getTaskType() === 'task') {
+                $(this.eventTarget).trigger({
+                    type: 'remove_option_page',
+                    component: this
+                });
+            } else {
+                // if it's block, just hide it
+                this.hide();
+            }
         }
 
         save() {
diff --git a/visualpython/js/menu/TaskItem.js b/visualpython/js/menu/TaskItem.js
@@ -39,10 +39,7 @@ define([
                 if (isOpen) {
                     // hide task if it's already opened
                     // open task
-                    $('#vp_wrapper').trigger({
-                        type: 'close_option_page',
-                        component: that.state.task
-                    });
+                    that.state.task.hide();
                 } else {
                     // open task
                     $('#vp_wrapper').trigger({
