This repository was archived by the owner on Feb 11, 2019. It is now read-only.
Show Composer failures to humans#55
Open
philsturgeon wants to merge 1 commit intovirtphp:masterfrom
philsturgeon:output-composer-failures
Open
Show Composer failures to humans#55philsturgeon wants to merge 1 commit intovirtphp:masterfrom philsturgeon:output-composer-failures
philsturgeon wants to merge 1 commit intovirtphp:masterfrom
philsturgeon:output-composer-failures
Conversation
Contributor
Author
|
Ok I know how to fix the tests but if I work on this any longer I'm gonna be late for dinner with @coderabbi. Will get it later/tomorrow. |
Member
|
Thanks for the work so far! |
Contributor
Author
|
I dont really understand the Virtphp\Test\Mock\ProcessMock class. It's a fake process class, which doesn't have |
There are so many things that can go wrong, that it would be useful to see what the actual issue was. For me in here #28 (comment) it was because I was not using a version of PHP that had openssl available. Without me seeing the output I'd never have had a clue about that.
Member
|
@philsturgeon again, sorry for limbo. Looks like you got the tests passing. Any other issues you are having? Also, can you pull master again and re-run the tests as the changes you made to ProcessMock might affect other tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are so many things that can go wrong, that it would be useful to see what the actual issue was. For me in here (#28 (comment)) it was because I was not using a version of PHP that had openssl available. Without me seeing the output I'd never have had a clue about that.