Improved test coverage of diff mode and fixed memory error#1685
Closed
dpelle wants to merge 7 commits intovim:masterfrom
Closed
Improved test coverage of diff mode and fixed memory error#1685dpelle wants to merge 7 commits intovim:masterfrom
dpelle wants to merge 7 commits intovim:masterfrom
Conversation
Member
Author
|
Interestingly, the newly added tests Test_diffopt_horizontal() and We could check that length of wp->w_p_fdm is I don't have a fix for this yet. |
Codecov Report
@@ Coverage Diff @@
## master #1685 +/- ##
=========================================
+ Coverage 74.85% 74.95% +0.1%
=========================================
Files 76 76
Lines 124942 124904 -38
=========================================
+ Hits 93521 93624 +103
+ Misses 31421 31280 -141
Continue to review full report at Codecov.
|
dpelle
changed the title
Member
Author
The heap overflow found by new tests is now fixed in this PR. |
When entering :diffsplit followed by :diffoff, w_p_fdm_save is empty and it is best to restore 'fdm' to "manual" rather than leaving set to 'diff'.
Contributor
|
Dominique Pellé wrote:
This PR improves test coverage of diff mode:
- test vertical, horizontal, iwhite and icase values of 'diffopt' option
- test normal commands "dp" and "do" with a buffer number
With a sequence of changes like this, I can't possibly tell when it's
done. Please add a comment when this is ready to include.
Also, a comment at that start that it's not ready yet would avoid
including it too early.
…--
FROG: How you English say: I one more time, mac, I unclog my nose towards
you, sons of a window-dresser, so, you think you could out-clever us
French fellows with your silly knees-bent creeping about advancing
behaviour. (blows a raspberry) I wave my private parts at your aunties,
you brightly-coloured, mealy-templed, cranberry-smelling, electric
donkey-bottom biters.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
Member
Author
PR is ready to be included. |
Contributor
|
Dominique wrote:
> With a sequence of changes like this, I can't possibly tell when it's done.
> Please add a comment when this is ready to include.
PR is ready to be included.
Thanks, I'll add it to the list.
…--
"I love deadlines. I especially like the whooshing sound they
make as they go flying by."
-- Douglas Adams
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: diff mode is insufficiently tested Solution: Add more test cases. (Dominique Pelle, closes vim#1685)
dpelle
pushed a commit
to dpelle/vim
that referenced
this pull request
Jul 31, 2017
Problem: diff mode is insufficiently tested Solution: Add more test cases. (Dominique Pelle, closes vim#1685)
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Jan 21, 2018
Problem: diff mode is insufficiently tested Solution: Add more test cases. (Dominique Pelle, closes vim/vim#1685) vim/vim@79a213d NA / already applied: --------------------- vim-patch:8.0.0421: diff mode wrong when adding line at end of buffer Problem: Diff mode is displayed wrong when adding a line at the end of a buffer. Solution: Adjust marks in diff mode. (James McCoy, closes vim/vim#1329) vim/vim@f58a847
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Jan 21, 2018
Problem: diff mode is insufficiently tested Solution: Add more test cases. (Dominique Pelle, closes vim/vim#1685) vim/vim@79a213d NA / already applied: --------------------- vim-patch:8.0.0421: diff mode wrong when adding line at end of buffer Problem: Diff mode is displayed wrong when adding a line at the end of a buffer. Solution: Adjust marks in diff mode. (James McCoy, closes vim/vim#1329) vim/vim@f58a847
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage of diff mode: