build: Always check tgetent return code#1664
Closed
marv wants to merge 1 commit intovim:masterfrom
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1664 +/- ##
==========================================
+ Coverage 74.87% 74.9% +0.02%
==========================================
Files 76 76
Lines 124888 124888
==========================================
+ Hits 93516 93543 +27
+ Misses 31372 31345 -27
Continue to review full report at Codecov.
|
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: Configure check for return value of tgetent is skipped. Solution: Always perform the check. (Marvin Schmidt, closes vim#1664)
dpelle
pushed a commit
to dpelle/vim
that referenced
this pull request
Jul 31, 2017
Problem: Configure check for return value of tgetent is skipped. Solution: Always perform the check. (Marvin Schmidt, closes vim#1664)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks,
I finally found the root cause of the problem I experienced and reported in issue #1601 thanks to the extra information I got from #1634. I explicitly set the terminal library by passing
--with-tlib=ncurses. Due to the logic in the configure script this caused the check to determine whether the tgetent returns zero or non-zero when given a non-existent terminal. The check is only run when$olibs != $LIBSwhich is not met when--with-tlibis passed, because in that case$LIBSis intentionally set to$olibsin oder to meet the$olibs = $LIBScondition of the subsequent check for the functiontgetent. ThereforeTGETENT_ZERO_ERRwon't be defined even if the specified terminal library returns zero.My best judgement is that the check should be run no matter if the terminal library was explicitly given or automatically selected. The proposed patched removes the condition around the check, so that it's always run