Skip to content

Properly split attribute strings, even if they have sub attributes - #15

Merged
kunzimariano merged 1 commit into
versionone:masterfrom
folti:master
Aug 6, 2014
Merged

kunzimariano merged 1 commit into
versionone:masterfrom
folti:master

Conversation

@folti

@folti folti commented Jul 25, 2014

Copy link
Copy Markdown

The SDK improperly procesess both search strings and server
responses for said search strings, if the original search string
contains filters between '[]' and said filter contain a '.'.

Example:
Original search string: History[Status.Name='Done']
This will be processed as ["History[Status", "Name='Done']"]

The SDK improperly procesess both search strings and server
responses for said search strings, if the original search string
contains filters between '[]' and said filter contain a '.'.

Example:
Original search string: History[Status.Name='Done']
This will be processed as ["History[Status", "Name='Done']"]
kunzimariano added a commit that referenced this pull request Aug 2, 2014
-Added string_utils module with the function split_attribute.
- Replaced the string split on dots for the new function.
- Added tests for split_attribute.
@kunzimariano
kunzimariano merged commit bad0985 into versionone:master Aug 6, 2014
@kunzimariano

Copy link
Copy Markdown
Contributor

Thanks for your contribution, we accepted your pull request.
Since the solution was failing we made some changes and added some unit tests.

Let us know if the changes we made are still valid for the issues you were having.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants