Remove stray double-quote from simple-layout wrapper div in File, Group and Password inside a MultiField - #213
Merged
Conversation
rvanbaalen
changed the title
rvanbaalen
changed the title
File, Group and Password emitted <div class="...""> in their MultiField (simple-layout) branch. Adds a regression test per class. Closes validformbuilder#205.
flangfeldt
force-pushed
the
fix/issue-205
branch
from
September 13, 2026 19:10
21c9a3b to
3436cae
Compare
flangfeldt
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #205
What changed
File,GroupandPasswordrendered<div class="vf__multifielditem"">(extra") in the MultiField simple-layout branch. The stray\"is removed in all three. No other occurrence exists inclasses/.To verify
fix/issue-205vendor/bin/phpunit --filter WellFormedclasses/ValidFormBuilder/{File,Group,Password}.phpto see them fail.Tests
FileTest::toHtmlSimpleLayoutWrapperDivIsWellFormedGroupTest::toHtmlSimpleLayoutWrapperDivIsWellFormedPasswordTest::simpleLayoutWrapperDivIsWellFormedPasswordTestand its weakassertStringContainsString("\">\n")check, which would still pass after the fix.Full suite: 955 tests green on PHP 8.2, 8.3, 8.4.