Feat: allow null and empty arrays for optional array attributes - #80
Merged
Merged
Conversation
kodumbeats
marked this pull request as draft
October 29, 2021 20:01
kodumbeats
marked this pull request as ready for review
November 2, 2021 00:38
1 task
TorstenDittmann
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Edge cases around validating arrays kept popping up, so I've cleaned up the logic of the Structure validator, and that covered all cases where the incorrect validator was applied. This change was required because array attributes were validated with the wrong validator. Additionally, this change accepts empty arrays as well as null for optional array attributes.
Tests
Additional unit tests have been added to Structure tests to check these cases.
Bug
optional URL array attribute is required
Request
Error
Structure