Fixed issue with parsing via trigger source with leading comments#940
Merged
Fixed issue with parsing via trigger source with leading comments#940
Conversation
lwasylow
approved these changes
Jun 16, 2019
Member
|
In build there is some odd log out during installation : |
lwasylow
approved these changes
Jun 16, 2019
Timing before change (with dbms_lob.read): `clob_to_table - Took:+000000000 00:00:00.012957000` After change: `clob_to_table - Took:+000000000 00:00:00.001236000` Speed improved by order of magnitude.
lwasylow
approved these changes
Jun 16, 2019
Member
Author
|
The message comes from script: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves problem when sources are passed via JDBC or dynamic SQL for compilation and source code contains leading comments.
The code was adjusted to properly read sources even when they are getting passed with leading comments containing create package statement.
Now, the following will be properly parsed: