Skip to content

Support native JSON data type of Oracle Database 21c#1181

Merged
lwasylow merged 12 commits intodevelopfrom
feature/1114_support_native_json_21c
Feb 6, 2022
Merged

Support native JSON data type of Oracle Database 21c#1181
lwasylow merged 12 commits intodevelopfrom
feature/1114_support_native_json_21c

Conversation

@lwasylow
Copy link
Member

@lwasylow lwasylow commented Feb 1, 2022 •
edited
Loading

Introducing a support for native json in 21c.
Fixing issue with act and exp
Closes #1114
Closes #1113

@lwasylow lwasylow linked an issue Feb 1, 2022 that may be closed by this pull request
Support native JSON data type of Oracle Database 21c #1114
Closed
@lwasylow lwasylow requested review from PhilippSalvisberg, jgebal and pesse and removed request for Pazus, PhilippSalvisberg and jgebal February 1, 2022 08:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jgebal
Copy link
Member

jgebal commented Feb 5, 2022

Can you also add a comment to the documentation related to the fact that DB upgrade will require utPLSQL to be re-installed?

If you're on say 18c and go to 21c, utPLSQL new features (native JSON) will not work without reinstall.
This is because we create a local stub type for JSON on lower versions of oracle.
The same rule applies for upgrade to 12.2, where JSON was initially introduced (JSON_Element_T).

A note on the upgrade of DB with utPLSQL will definitely help.

jgebal
jgebal approved these changes Feb 6, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 6, 2022 •
edited
Loading

Codecov Report

Merging #1181 (e44830b) into develop (d81824a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1181   +/-   ##
========================================
  Coverage    94.85%   94.86%           
========================================
  Files          104      104           
  Lines         4844     4853    +9     
  Branches        21       21           
========================================
+ Hits          4595     4604    +9     
  Misses         241      241           
  Partials         8        8
Flag Coverage Δ
11xe 94.17% <0.00%> (-0.06%) ⬇️
18xe 94.53% <0.00%> (-0.16%) ⬇️
21xe 94.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/api/ut.pkb 93.26% <100.00%> (+0.06%) ⬆️
...pectations/data_values/ut_compound_data_helper.pkb 98.68% <100.00%> (+0.01%) ⬆️
...ce/expectations/data_values/ut_data_value_json.tpb 98.46% <100.00%> (+0.07%) ⬆️
source/expectations/matchers/ut_equal.tpb 100.00% <100.00%> (ø)
source/expectations/ut_expectation.tpb 98.74% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81824a...e44830b. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2022 •
edited
Loading

Unit Test Results

       1 files  ±  0         2 suites  ±0   1m 32s ⏱️ - 1m 11s
1 022 tests +31  1 018 ✔️ +31  4 💤 ±0  0 ❌ ±0 
1 025 runs  +31  1 017 ✔️ +31  8 💤 ±0  0 ❌ ±0 

Results for commit e44830b. ± Comparison against base commit d81824a.

♻️ This comment has been updated with latest results.

jgebal
jgebal reviewed Feb 6, 2022
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@lwasylow lwasylow merged commit ab1acfa into develop Feb 6, 2022
@jgebal jgebal deleted the feature/1114_support_native_json_21c branch February 6, 2022 18:51
@jgebal jgebal added this to the 3.1.12 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgebal jgebal jgebal approved these changes

@pesse pesse Awaiting requested review from pesse

@PhilippSalvisberg PhilippSalvisberg Awaiting requested review from PhilippSalvisberg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1.12

Development

Successfully merging this pull request may close these issues.

Support native JSON data type of Oracle Database 21c Actual reported as expected and vice versa for JSON_ELEMENT_T

2 participants

@lwasylow @jgebal