fix: correct version header output and improve Experimental variable documentation#8519
Open
JiayangLai wants to merge 1 commit intoupdatecli:mainfrom
Open
fix: correct version header output and improve Experimental variable documentation#8519JiayangLai wants to merge 1 commit intoupdatecli:mainfrom
JiayangLai wants to merge 1 commit intoupdatecli:mainfrom
Conversation
…documentation - Remove unnecessary strings.ToTitle() call in version command which was incorrectly uppercasing the "Version" header to "VERSION" - Add documentation comment to Experimental variable explaining its purpose and how it is set - Remove unused "strings" import from cmd/version.go Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code review of the 5 oldest code files in the repository revealed two issues that have been fixed:
cmd/version.go:18 - Fixed incorrect string formatting in version command
logrus.Infof("\n%s\n", strings.ToTitle("Version"))logrus.Infof("\n%s\n", "Version")strings.ToTitle("Version")call was incorrectly converting "Version" to "VERSION" (all uppercase), which doesn't match the expected output format. Removed the unnecessarystringsimport as well.pkg/core/cmdoptions/main.go - Added documentation for the Experimental variable
--experimentalflag.var Experimental bool = falsetovar Experimental = falsefor consistency (type inference is preferred when the type is obvious).Test plan
🤖 Generated with Claude Code