Repository navigation
Add Inbox Cleanup to standards-based mail - #504
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (6).changeset/**/*📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/unwired-mail/**/*.{swift,m,mm}📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/unwired-mail/**/*.swift📄 CodeRabbit inference engine (AGENTS.md)
Files:
⚙️ CodeRabbit configuration file
Files:
README.md📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.md⚙️ CodeRabbit configuration file
Files:
**/*Tests/**/*.swift⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (2)📚 Learning: 2026-08-06T06:40:04.308ZApplied to files:
📚 Learning: 2026-08-06T06:40:04.308ZApplied to files:
🪛 markdownlint-cli2 (0.23.2).changeset/calm-owls-clean.md[warning] 5-5: First line in a file should be a top-level heading (MD041, first-line-heading, first-line-h1) 🔇 Additional comments (4)
📝 WalkthroughSummary
Validation
WalkthroughInbox Cleanup now includes eligible Standards-Based Mail connections. Tests cover mapped mailbox roles, UIDPLUS support, sender identity, and unsupported connection types. The UI and documentation describe Trash-based recovery and automatic Undo limits. ChangesInbox Cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🟡 Moderate · up to Verified MOVE support for mapped Trash is not currently treated as eligible, which may prevent Inbox Cleanup from working for supported mailboxes; merge should wait for the eligibility logic, test, and documentation to agree. Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77df3d6ad8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Closes #351
Validation
mise exec -- xcrun swift-format lint --stricton all changed Swift files — passedswiftlint lint --strict --no-cacheon all changed Swift files — passedxcodebuild test ... -only-testing:unwired-mailTests/InboxCleanupTestson Mac Catalyst — passed, 11 testsIMAPMailboxConnectionAdapterTestsfor UIDPLUS uncertainty recovery and native-move stable identity — passed, 2 testsbuild-for-testingonD6D43A14-3B1A-41B6-B25A-0DFCA1BFB089— passedtestmanagerdUnix-domain socket did not existscripts/check-apple-lint.zsh— recursive strictswift-formatpassed; SwiftLint reported only the existing untouchedBlockedSenderSyncService.swift:51651-line function-body violation, plus its sandbox cache-write warninggit diff --check— passedRemaining human action
None beyond normal review and hosted CI. The local Simulator runner failure above is preserved for visibility; the implementation and deterministic focused coverage are complete.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.