Repository navigation
Stabilize Apple simulator test runs - #276
Merged
Merged
Conversation
Contributor
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughSummary
Validation
WalkthroughThe changes isolate attachment eviction notifications with dependency injection and update mailbox adapter tests to create windows from connected scenes. The shared Xcode scheme disables test parallelization. ChangesTest isolation and scene-aware fixtures
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
rajzik
marked this pull request as ready for review
August 4, 2026 08:37
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UIWindowSceneRoot cause
Parallel execution launched several complete app-hosted Simulator clones. Once one test process crashed or stalled, SpringBoard and RunningBoard denied later app launches as busy. Three independent test-fixture problems amplified that failure cascade: an eviction notification escaped into the next test iteration, a generation-gate test entered the real credential service before reaching its intended rendezvous, and detached UIKit windows never produced SwiftUI row lifecycle callbacks.
Impact
The documented local Apple test command now follows the stable serial behavior already used by CI. Runtime attachment notifications still use
NotificationCenter.default; the injected center is an internal test seam.Validation
mise exec -- zsh scripts/check-apple-lint.zshmise exec -- xcodebuild test -project apps/unwired-mail/unwired-mail.xcodeproj -scheme unwired-mail -destination 'platform=iOS Simulator,name=iPhone 17'— 1,450 passed, 0 failedgit diff --checkNo documentation or changeset is required because the documented command and product behavior are unchanged.
Related to #275.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.