Repository navigation
Ship current Vulkan prebuilts and restore Volta CUDA support - #22
Merged
danielhanchen merged 3 commits intoOct 7, 2026
Merged
Conversation
This was referenced Oct 6, 2026
Merged
Member
Author
|
Reached Codex review convergence at oobabooga#1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MiniMax-H3's Vulkan path can crash during denoising on Linux or abort while loading the text encoder on Windows. The fixes are already in this repository, but Studio gets an older upstream Vulkan build because this workflow does not publish Vulkan assets.
The Linux CUDA prebuilt also has no
sm70kernels, so it cannot run on a V100 even though the device probe can list the card.Root cause
The older Vulkan build failed in two different places on the AMD runners:
Current source restores the graph state between segments and keeps supported BF16 embedding weights in BF16. This PR packages those fixes for Vulkan.
Fix
sd-cliandsd-serverfor Linux x86_64 Vulkan and Windows x64 Vulkan. The Windows binaries go through the existing signing steps.glslc, which Ubuntu 22.04 does not package.70to the Linux CUDA architectures.Both Vulkan assets are required for publication. A Vulkan build failure therefore blocks CPU and Apple releases too. Allowing a release without them would leave affected AMD users on the older fallback after the Studio pin update. CUDA keeps its existing best-effort policy.
After merging, publish the native release, then update Studio's prebuilt pin. unslothai/unsloth#12902 fixes Windows CPU selection when a release contains both CPU and Vulkan assets.
Testing
Live A/B on the AMD DevLab Linux and Windows runners, both with a Radeon 8060S. Old source
bfbef5bagainst current source7bbffa3, using Q4, 1344x768, 124 frames, two denoising steps and a 20 GiB VRAM budget.All 124 frames and the audio decoded successfully on both. An isolated backport of the graph-state fix also completed the Linux run.
Linux run / Windows run
sd-cliandsd-serverbuilt, were packaged and extracted through Studio's installer helpers, and loaded in an Ubuntu 22.04 container without the SDK mounted. Their highest required GLIBC symbol version is 2.34. The GPU run was not repeated with this package.glslcfrom the SDK. The fingerprint check covered all eight bundles, and the coverage gate found all seven required assets.sm_70kernels in bothsd-cliandsd-server, alongsidesm_75throughsm_120a.Not tested:
DeviceLostfailure was not reproduced identically on the 8060S.