fix: scope alternate link dedupeKey by href when type is used#760
Merged
Conversation
Backport of #759 to v2. Multiple RSS/Atom alternate links sharing the same `type` but with different `href` values were being collapsed into one tag because the dedupe key was built from `type` alone. Include `href` in the key for type-based alternates so distinct feeds are preserved. `hreflang` precedence is unchanged. Fixes #758
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
harlan-zw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #759 to the v2 branch.
Problem
Multiple RSS/Atom
<link rel="alternate">tags sharing the sametypebut with differenthrefvalues were being collapsed into one tag, becausededupeKeyfor alternates was built fromtypealone.Fix
Use
hreflangalone as the key when present (language variants are uniquely identified by it). For type-based alternates, includehrefin the key so distinct feeds are not conflated.Fixes #758