Skip to content

fix(node): tty default export for ReadStream#513

Merged
pi0 merged 1 commit into
mainfrom
fixup-tty-polyfill-export
Aug 3, 2025
Merged

fix(node): tty default export for ReadStream#513
pi0 merged 1 commit into
mainfrom
fixup-tty-polyfill-export

Conversation

@jasnell

@jasnell jasnell commented Aug 2, 2025

Copy link
Copy Markdown
Contributor

Fixes: #512

@pi0 pi0 changed the title Fix tty default export for ReadStream fix(node): tty default export for ReadStream Aug 3, 2025

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 merged commit 00ab5d8 into main Aug 3, 2025
2 checks passed
@pi0 pi0 deleted the fixup-tty-polyfill-export branch August 3, 2025 19:08
@pi0

pi0 commented Aug 3, 2025

Copy link
Copy Markdown
Member

Does this need immediate release?

(fix is already available in nightly channel. i have few more items to batch-in if not urgent)

@vicb

vicb commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Hey @pi0
It would be helpful to have a release either today or tomorrow.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node:tty polyfill default export mistakenly exports ReadStream as WriteStream

4 participants