Add and remove liquidity tests are not working correctly #1

Activity

1. shanefontaine

   added

   bugSomething isn't workingSomething isn't working

   on Jan 3, 2019
2. shanefontaine commented on Jan 4, 2019

   

   shanefontaine

   on Jan 4, 2019

   CollaboratorAuthor

   More actions

   The make_trade with recipient calls also intermittently fail.

   Example
3. shanefontaine commented on Jan 4, 2019

   

   shanefontaine

   on Jan 4, 2019

   Last edited by shanefontaine

   CollaboratorAuthor

   More actions

   Seemingly _token_to_eth_swap_output and _token_to_eth_transfer_output are the only two failing and it only happens during testing when multiple transactions process simultaneously. Calling them normally works fine.
4. shanefontaine commented on Jan 4, 2019

   

   shanefontaine

   on Jan 4, 2019

   CollaboratorAuthor

   More actions

   Apparenlty the issues were fixed with these two commits.

   I am not totally sure what did it. It looks like raising the amount sent help.

   Following the rounding suggestion here seemed to help the add_liquidity function. Will reopen if issue persists.
5. shanefontaine

   closed this as completedon Jan 4, 2019