Deprecate legacy typeless addAssertion#581
Merged
Merged
Conversation
Member
Author
|
Nice bonus info: After I changed the legacy assertions in the test suite, the check from #372 caught a handful of cases where the assertion handler mistakingly expected too many parameters. For example here: e443792?utf8=%E2%9C%93&diff=unified#diff-9d6bc70c1052e54f3f3bcbb165f036a8L258 |
sunesimonsen
approved these changes
Jan 21, 2019
sunesimonsen
left a comment
sunesimonsen
left a comment
Member
There was a problem hiding this comment.
Yes 👍 we should have killed it in v11, but now let's do it in v12.
alexjeffburke
approved these changes
Jan 21, 2019
alexjeffburke
left a comment
alexjeffburke
left a comment
Member
There was a problem hiding this comment.
Yes! The fact that we have this in the core test suite is as good an indication as any that the time has come. I also found (and fixed) a couple of cases of this in plugins during the v11 work. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339
I think we should get this in now, as it will make
addAssertionless confusing per the linked issue. Then we can remove the support in Unexpected 12 or 13.