fix: preserve colspan and rowspan in HTML table cleaning#1987
Open
cgseyhan wants to merge 1 commit into
Open
Conversation
This commit adds colspan and owspan to IMPORTANT_ATTRS in config.py so that these table structure attributes are preserved during sanitization. Also added a unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the Issue?
During the HTML sanitization and cleaning phase, essential structural table attributes (
colspanandrowspan) were inadvertently being stripped away.The Solution
To fix this, I updated the global sanitization rules to explicitly preserve table layout attributes.
Changes Made:
"colspan"and"rowspan"to theIMPORTANT_ATTRSlist insidecrawl4ai/config.py.BeautifulSoup-based cleaner retains these crucial attributes for<td>and<th>elements during the DOM processing phase.Testing & Verification
I implemented robust testing to ensure this bug doesn't return:
tests/test_html_table_colspan_rowspan.pyAsyncWebCrawlerwith araw:HTML string containing a complex table setup.colspan="2"androwspan="2"attributes.