ci: cap runtime on every job in the shared workflows - #27
Merged
Conversation
No job in this repo set timeout-minutes, so each one inherited GitHub's 6-hour default. A test that hangs rather than fails then sits amber for hours and blocks the branch instead of going red in minutes — which is exactly what happened across the org today when a dropped transitive dep left browserify's suite hanging. Cap every job that owns a runner. The two thin caller jobs (commitlint, renovate-config) are left alone: GitHub does not accept timeout-minutes on a job that calls a reusable workflow, and the reusable workflow they call now carries its own cap, so forks inherit the limit either way. Co-Authored-By: Claude <[email protected]> Claude-Session: https://claude.ai/code/session_01YLKEpDeq7NbnC2rbyWpSfa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
No job in this repo set
timeout-minutes, so every job — in the shared reusable workflows and in this repo's own workflows — inherited GitHub's 6-hour default.That turned a hanging test into a 6-hour amber block rather than a fast red. It bit us today:
@unabandoned/module-deps6.2.8 replaced itssubargdependency withminimist, which removedsubargfrom browserify's install tree (no lockfile, range^6).test/array.jsstill resolvedsubargby bare name, and the resulting failure left the runner unable to exit, sonpm testhung. Both the master run and every open PR's CI sat in progress indefinitely instead of failing in seconds. (The browserify-side fix is separate — this PR is only about the blast radius.)Caps added, sized against observed run times (the whole CI workflow currently finishes in 30–90s):
reusable-citestreusable-cimetadatareusable-codeqlanalyzereusable-commitlintcommitlintreusable-publishpublishreusable-release-cutcutreusable-release-pleaserelease-pleasereusable-release-securitysecurity-releasereusable-renovate-configvalidatereusable-scorecardanalysisrelease-reusablereleasedashboardbuilddashboarddeployThe two thin caller jobs (
commitlint,renovate-config) are deliberately untouched: GitHub does not accepttimeout-minuteson a job that calls a reusable workflow. The reusable workflows they call now carry their own caps, so forks inherit the limit through theuses:ref either way — no per-fork change needed.Type of change
fix/feat/perf— consumer-facingdeps— dependency update (add thesecuritylabel if it fixes a CVE)chore/ci/build/docs/test/refactor— maintenanceChecklist
commitlintpasses)npm testpasses on Node 20 / 22 / 24 — no package code touched; workflow YAML only, parsed and asserted job-by-job to confirm every runner-owning job now carries a capnode:testover new runners)Generated by Claude Code