fix problems in gcm lesson#52
Merged
danielmai merged 1 commit intoudacity:5.04_Receiving_a_Messagefrom Dec 30, 2015
Merged
Conversation
maloef
commented
Dec 24, 2015
maloef
commented
- remove gcm_defaultSenderId from strings.xml as this is generated automatically from google-services.json
- add missing dots in front of package names in manifest (gcm.* -> .gcm.*)
- upgrade to newest play services version (ListenerService didn't receive message otherwise)
- fix format of response bundle in MyGcmListenerService
- remove gcm_defaultSenderId from strings.xml as this is generated automatically from google-services.json - add missing dots in front of package names in manifest (gcm.* -> .gcm.*) - upgrade to newest play services version (ListenerService didn't receive message otherwise) - fix format of response bundle in MyGcmListenerService
beepscore
added a commit
to beepscore/Sunshine
that referenced
this pull request
Dec 27, 2015
Reference fix problems in gcm lesson #52 Pull request by maloef udacity/Advanced_Android_Development#52
beepscore
added a commit
to beepscore/Sunshine
that referenced
this pull request
Dec 27, 2015
…equest. This fixes a crash. Revise comments. udacity/Advanced_Android_Development#52
Contributor
|
Perfect! Thanks for making these changes, @maloef. |
Author
|
Hi Daniel, cool - thank you! Markus On 30.12.2015 22:47, Daniel Mai wrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.