test_device_brandmodel.yaml merged into test_device.yaml - #3
Merged
Merged
Conversation
Contributor
Author
|
@elsigh Can you please look into this? tobie wanted to have one large testset, so this PR reflects this. |
Contributor
Author
|
I had to update the reference to uap-core submodule. Thats reflected in the last change. |
Ironholds
added a commit
that referenced
this pull request
Jan 18, 2015
test_device_brandmodel.yaml merged into test_device.yaml
Contributor
|
Thanks! Sorry for the delay? |
throwanexception
pushed a commit
to throwanexception/uap-python
that referenced
this pull request
Mar 30, 2018
lihuanshuai
added a commit
to lihuanshuai/uap-python
that referenced
this pull request
Sep 5, 2018
fixed ios mobile safari verion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of ua-parser/uap-core#10 (comment) the test cases from test_device_brandmodel.yaml are now merged into test_device.yaml.
This requires an adaptation of the tests.