Commits

Branch selector

 main

User selector

All users

All time

Commit history

Commits on Jun 21, 2022

• Update README.md

  tzef

  authored
  6623252

  Copy full SHA for 6623252

• Create README.md

  tzef

  authored
  0a42cea

  Copy full SHA for 0a42cea

Commits on Jun 19, 2022

• Bump search module to 1.1.0

  tzef

  committed
  22001d8

  Copy full SHA for 22001d8

• Add dependency by SPM and fix miss importing Foundation compile error

  tzef

  committed
  73d1bad

  Copy full SHA for 73d1bad

• Add gitignored for SPM

  tzef

  committed
  4f1c861

  Copy full SHA for 4f1c861

• Remove all frameworks from workspace and example project

  tzef

  committed
  fce827d

  Copy full SHA for fce827d

Commits on Jun 18, 2022

• Because we improve API module by adding API client as the service interface, can remove the public from API manager

  tzef

  committed
  67e121d

  Copy full SHA for 67e121d

• Add empty instance respect to open-close principle, let caller side has flexible to compose with other protocols

  tzef

  committed
  6c842a1

  Copy full SHA for 6c842a1

• Remove public whole controller by the service layer protocol and generated by factory

  tzef

  committed
  679a69a

  Copy full SHA for 679a69a

• Remove observer from search, as the binding is specific for String type in search module

  tzef

  committed
  6b66f87

  Copy full SHA for 6b66f87

• Add representable interface to details module for displaying the Search Item

  tzef

  committed
  d02cb05

  Copy full SHA for d02cb05

• Add representable interface to listing for accessing the GithubSearchModel.Item

  tzef

  committed
  bdb321a

  Copy full SHA for bdb321a

Commits on Jun 11, 2022

• Remove public from search service, since we move the implementation to the inside self module, add another APIService for communicating infra layer

  tzef

  committed
  cb21778

  Copy full SHA for cb21778

• RepositoryListSearchController can remove generic observer as it's clear for string type, then can remove public from Observer as well

  tzef

  committed
  7237f1b

  Copy full SHA for 7237f1b

• Already hide the response converting logic from composition, keep in repository, so can remove the public from search response

  tzef

  committed
  2a9082d

  Copy full SHA for 2a9082d

• API Request and API Resource are required to public but GithubResource is not, because we have protocol to communicate between modules

  tzef

  committed
  9cd3af8

  Copy full SHA for 9cd3af8

• Remove public from details view to hide the details from outside

  tzef

  committed
  4efaa4b

  Copy full SHA for 4efaa4b

• Remove public from list view controller by changing return type to UIViewController, not exposed the details of list view

  tzef

  committed
  32730f2

  Copy full SHA for 32730f2

• Extract search status to refresh controller status mapping logic from extension constructor to an individual mapper

  tzef

  committed
  4de5b57

  Copy full SHA for 4de5b57

• Extract search status to refresh controller status mapping logic from extension constructor to an individual mapper

  tzef

  committed
  5ee857d

  Copy full SHA for 5ee857d

• Extract search model to list cell view model converting logic to mapper for listing module

  tzef

  committed
  9540ed2

  Copy full SHA for 9540ed2

• Move private scope order down

  tzef

  committed
  26535c7

  Copy full SHA for 26535c7

• Extract details cell model building logic to mapper

  tzef

  committed
  d72276d

  Copy full SHA for d72276d

• Add mapper for specific the mapping logic to details UI factory in composition module, instead of the extension init mapper

  tzef

  committed
  50f452a

  Copy full SHA for 50f452a

• Explicitly the mapping behavior by injecting the status mapper to search controller, and moving the type converting from extension to mapper

  tzef

  committed
  abcb636

  Copy full SHA for abcb636

• Extract details ui factory to own file

  tzef

  committed
  20e9dc2

  Copy full SHA for 20e9dc2

• Implement details ui factory of listing module in composition module, remove the listing router delegate

  tzef

  committed
  a1f9002

  Copy full SHA for a1f9002

• In order to keep navigation logic in router, change delegate to ui factory protocol for getting the next page

  tzef

  committed
  e9a81fa

  Copy full SHA for e9a81fa

• Github search service implemented by search repository within self module, change the constructor replace the injected object with APIService in composition module

  tzef

  committed
  aad1647

  Copy full SHA for aad1647

• Add APIRequest, APIResource and APIService protocol instead of the role of concrete API module to let Listing module compilable

  tzef

  committed
  59ec84c

  Copy full SHA for 59ec84c

• We want to keep domain details in domain module, add search repository conform the search service, TODO: decouple API infra from repository

  tzef

  committed
  8012273

  Copy full SHA for 8012273

• Reorganize the files structure in composition module, from grouping by type to grouping by features

  tzef

  committed
  21406dd

  Copy full SHA for 21406dd

• Add Module UI to composition module and poss the implementor of design system to composers of feature modules

  tzef

  committed
  428a82e

  Copy full SHA for 428a82e

• Update Module UI conforming design system, as Module UI is a conformist role in project

  tzef

  committed
  ccc356c

  Copy full SHA for ccc356c

• Inject design system implementation to listing, details and search module via factory

  tzef

  committed
  dd194ee

  Copy full SHA for dd194ee