Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Revert "Include timezone info for timestamps in search query" - #69

Merged
walro merged 2 commits into
masterfrom
revert-67-include-timezone-in-timestamps
Oct 16, 2017
Merged

walro merged 2 commits into
masterfrom
revert-67-include-timezone-in-timestamps

Conversation

@walro

@walro walro commented Oct 16, 2017

Copy link
Copy Markdown
Contributor

Reverts #67

Search API V3 should not be queried with timezone information, including the information may yield unexpected results.

@roback roback left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

To get one without V3’s datetime timezone offset bug.
walro added a commit to twingly/twingly-search-api-python that referenced this pull request Oct 16, 2017
Same as twingly/twingly-search-api-ruby#69.

Re-record fixtures to get fixtures without published time bugs.
@walro
walro merged commit de99aa4 into master Oct 16, 2017
@walro
walro deleted the revert-67-include-timezone-in-timestamps branch October 16, 2017 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants