Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Actually test what we intend to test - #52

Merged
dentarg merged 3 commits into
masterfrom
fix-should-not-modify-time-tests
Feb 25, 2016
Merged

dentarg merged 3 commits into
masterfrom
fix-should-not-modify-time-tests

Conversation

@dentarg

@dentarg dentarg commented Feb 25, 2016

Copy link
Copy Markdown
Contributor

@dentarg

dentarg commented Feb 25, 2016

Copy link
Copy Markdown
Contributor Author

Oh, we are running into https://byparker.com/blog/2014/ruby-2-2-0-time-parse-localtime-regression/, the tests fails for Ruby < 2.2.

[4] pry(main)> RUBY_VERSION
=> "2.1.5"
[5] pry(main)> require "time"
=> true
[7] pry(main)> time_str = "2016-02-09 09:01:22 +0500"
=> "2016-02-09 09:01:22 +0500"
[14] pry(main)> Time.parse(time_str)
=> 2016-02-09 05:01:22 +0100
[1] pry(main)> RUBY_VERSION
=> "2.2.4"
[2] pry(main)> require "time"
=> true
[3] pry(main)> time_str = "2016-02-09 09:01:22 +0500"
=> "2016-02-09 09:01:22 +0500"
[4] pry(main)> Time.parse(time_str)
=> 2016-02-09 09:01:22 +0500

@roback

roback commented Feb 25, 2016

Copy link
Copy Markdown
Member

LGTM! :shipit:

dentarg added a commit that referenced this pull request Feb 25, 2016
@dentarg
dentarg merged commit d8107db into master Feb 25, 2016
@dentarg
dentarg deleted the fix-should-not-modify-time-tests branch February 25, 2016 15:02
roback added a commit that referenced this pull request Mar 3, 2016
* Be able to remove start/end time from a query (#54)
* Improve tests (#52)
* Sync documentation with other clients
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants