Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Improve parser specs - #49

Merged
dentarg merged 3 commits into
masterfrom
improve-parser-specs
Feb 17, 2016
Merged

dentarg merged 3 commits into
masterfrom
improve-parser-specs

Conversation

@dentarg

@dentarg dentarg commented Feb 17, 2016

Copy link
Copy Markdown
Contributor

Not the prettiest tests in the world, but now we actually check the result from the parsing.

Not the prettiest tests in the world, but now we actually check
the result from the parsing.
@dentarg

dentarg commented Feb 17, 2016

Copy link
Copy Markdown
Contributor Author

Motivated by the fact that we in twingly/twingly-search-api-node#10 discovered that the parsing of <tags> probably is incorrect.

Comment thread spec/parser_spec.rb Outdated
let(:fixture) { :minimal_valid }

describe "#posts[0]" do
let(:post) { result.posts[0] }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no functional difference (that I know of), but I'm thinking maybe this could be:

subject(:post) { result.posts[0] }

Since it would indicate the it's the post that's being tested.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@jage

jage commented Feb 17, 2016

Copy link
Copy Markdown
Contributor

LGTM!

dentarg added a commit that referenced this pull request Feb 17, 2016
@dentarg
dentarg merged commit b529923 into master Feb 17, 2016
@dentarg
dentarg deleted the improve-parser-specs branch February 17, 2016 11:59
<languageCode>sv</languageCode>
<published>2013-01-29 15:21:56Z</published>
<indexed>2013-01-29 15:22:52Z</indexed>
<blogUrl>http://www.skvallernytt.se/</blogUrl>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a blog? 😄

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😜

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants