Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Parse coordinates correctly - #35

Merged
roback merged 3 commits into
masterfrom
issue/34/parse-coordinates-correctly
Jun 1, 2017
Merged

roback merged 3 commits into
masterfrom
issue/34/parse-coordinates-correctly

Conversation

@roback

@roback roback commented May 29, 2017 •

Copy link
Copy Markdown
Member

close #34
close #36

Comment thread tests/test_parser.py Outdated

self.assert_blog_posts_equal(posts[0], expectedPost)

def test_valid_links_result(self):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe, the name is not correct here :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in cbe524f :)

@dentarg

dentarg commented May 30, 2017

Copy link
Copy Markdown
Contributor

We talked about having longitude and latitude directly on the Post object, I think that makes sense.

@dentarg dentarg assigned dentarg and unassigned dentarg May 30, 2017
roback added 2 commits May 30, 2017 10:13
This way latitude and longitude is always set. If the post has no
coordinates, latitude and longitude will be None.
The tags are always set to an empty array by the parser, so this
won't break anything since it is never used.

Im not sure whether 'or ""' that is used for all strings are really
needed, but I left those in case they are.
@roback
roback merged commit 0b4ef7d into master Jun 1, 2017
@roback
roback deleted the issue/34/parse-coordinates-correctly branch June 1, 2017 06:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coordinates on Post object Parse post coordinates correctly

2 participants