This repository was archived by the owner on Jun 8, 2026. It is now read-only.
Repository navigation
Parse coordinates correctly - #35
Merged
Merged
Conversation
dentarg
reviewed
May 30, 2017
|
|
||
| self.assert_blog_posts_equal(posts[0], expectedPost) | ||
|
|
||
| def test_valid_links_result(self): |
Contributor
There was a problem hiding this comment.
hehe, the name is not correct here :)
Contributor
|
We talked about having longitude and latitude directly on the |
This way latitude and longitude is always set. If the post has no coordinates, latitude and longitude will be None.
The tags are always set to an empty array by the parser, so this won't break anything since it is never used. Im not sure whether 'or ""' that is used for all strings are really needed, but I left those in case they are.
dentarg
approved these changes
May 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #34
close #36