Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Update client to Search API v3 - #18

Merged
dentarg merged 5 commits into
masterfrom
search-api-v3
May 29, 2017
Merged

dentarg merged 5 commits into
masterfrom
search-api-v3

Conversation

@roback

@roback roback commented May 5, 2017

Copy link
Copy Markdown
Member

The same changes as in the ruby client (twingly/twingly-search-api-ruby#65)

I noticed a few things that could be improved, but I think it's easier to handle those in a separate PR.
For example:

  • a few variables are still using snake_case
  • some tests changing the environment for other tests
  • recording fixtures requires you to remove your API key by editing the fixture by hand

@dentarg
dentarg self-requested a review May 29, 2017 12:56
@dentarg

dentarg commented May 29, 2017

Copy link
Copy Markdown
Contributor

I can add test for longitude/latitude of coordinates

@dentarg

dentarg commented May 29, 2017

Copy link
Copy Markdown
Contributor

Hmm, I think this should be fixed too, I can take a look.

$ dotenv node examples/hello_world.js
fullSearchQuery="hello world" start-date:2017-05-29 12:13:30
...

dentarg added 2 commits May 29, 2017 16:42
We can't have any spaces in the timestamp. Use ISO 8601 timestamps with
timezone information.
Improve the chance we get any hits, but limit the number of posts
displayed.
@dentarg

dentarg commented May 29, 2017

Copy link
Copy Markdown
Contributor

@roback I was going to request review by you but it's not possible :)

@roback

roback commented May 29, 2017

Copy link
Copy Markdown
Member Author

@roback I was going to request review by you but it's not possible :)

Hehe, I can take a look anyway :)

@roback roback left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dentarg
dentarg merged commit 8b064bf into master May 29, 2017
@dentarg
dentarg deleted the search-api-v3 branch May 29, 2017 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants