Repository navigation
Conversation
| Connection: keep-alive | ||
| Content-Length: '0' | ||
| Host: api.twingly.com | ||
| User-Agent: Twingly Search Java Client/null |
There was a problem hiding this comment.
Happened to notice /null here, is there some problem with reading the version from the property file?
There was a problem hiding this comment.
Hm. I've tried several solutions, so have only checked what's in response only for the first ones (everything was OK there). I'll check what could be wrong.
|
I guess you noticed the trouble with Java 7 |
|
Otherwise I think it looks good. How tricky would it be to incorporate this in the Spock/Groovy test suite? :) I understand it might not be worth it, but it would be cool if all tests were using the same test style, if possible. |
|
Ahh, yeah, I've forgotten about java7. |
Ah, that makes sense. |
rewrite UrlConnectionClientFunctionTest with groovy and Spock ensure that VERSION constant is always initialized after version property is gathered from version.properties.
|
I've rewritten test with groovy and Spock and also changed slightly VERSION constant, so now it will be 100% loaded after version property is gathered from version.properties. |
Nice, but it looks like a new error was introduced for Java8. Did it run fine locally for you? |
|
@walro I think it's some Travis-ci bug, cause on my branch tests passed for java 8 (as locally they are also OK). |
|
I think that branch could be only merged into your repo, when betamax will release a new snapshot. (betamaxteam/betamax#186) |
betamax-snapshot should be used until new stable release won't be presented.
|
Again some weird things happened. |
|
@xSAVIKx we are now using the latest snapshot of betamax, and that snapshot now (since 8 hours ago :) ) changes with every commit to the betamax repo the only real change that have been made to betamax, that I can spot, since we tried and jdk8 worked, is betamaxteam/betamax#180 (which fixes betamaxteam/betamax#179), could that affect what we are doing here? cc @cowboygneox |
|
@dentarg I'd understand, if my fork is failed also, but, you see, my fork was successfully built. And local build is also OK, so I cannot understand what's wrong. |
|
Ah that's strange... for the record, here is your green build: https://travis-ci.org/xSAVIKx/twingly-search-api-java/builds/115814335. I restarted our failing build: https://travis-ci.org/twingly/twingly-search-api-java/builds/115814365 |
|
@dentarg The change in betamaxteam/betamax#180 will only affect the default configuration, which will be to use the proxy. In most examples and usages, you won't use the default, and thus should have no impact. If you're not configuring the proxy, you're unlikely using Betamax effectively. |
|
This is really strange, https://travis-ci.org/twingly/twingly-search-api-java/builds/115814365 fails but not
thank you @xSAVIKx for the work here and thank you @cowboygneox for reviving betamax, I will be on the look out for the next relase :) |
|
@xSAVIKx when I ran locally, I noticed that |
|
I think I know the problem with Travis, it doesn't seem to run the latest commit... some sync issue |
No... |
|
I have now emailed travis ci support |
|
I also did the merge with master locally and ran the tests, worked fine |
|
@dentarg You should ignore those certs; they are generated as necessary for SSL support. If you commit them, they will likely expire some time in the future causing messy failures. I'll have to add that to the documentation on Betamax. |
@dentarg , as @cowboygneox already mentioned - these are generated certificates to support SSL, so yes, I think I should add them to .gitignore. |
add betamax-generated SSL certificated to gitignore
| cglibVersion = "3.2.0" | ||
| objenesisVersion = "2.2" | ||
| jaxbVersion = "2.2.11" | ||
| betamaxVersion = "2.0.0-alpha-1" |
There was a problem hiding this comment.
What is betamaxVersion used for? Seems to me that only betamaxSnapshotVersion is used.
There was a problem hiding this comment.
@walro I think it's left in so we can easily switch back when a proper release of betamax has been made
There was a problem hiding this comment.
Yeah, I thought it was something like that. I'd like it removed anyway, but we can do it ourselves.
There was a problem hiding this comment.
@walro Yeap it was just for simplification of future dependency version change.
|
@xSAVIKx do you mind trying to restart the tests for your repository? We're trying to figure out the Travis problem. We noticed that you used a slightly older version/build of Betamax (even though it should not matter). |
|
for "continuous-integration/travis-ci/push" we get Pretty sure the problem is that betamax isn't using the tape for "continuous-integration/travis-ci/pr", but as to why, I have no idea... |
|
@dentarg betamax tried to use tape, but, I think, smth happened while request was intercepted, cause in PR log, there's INFO: |
|
@xSAVIKx thanks for pointing that out, it's helpful Old but similar issue: betamaxteam/betamax#134 which says
Sounds a bit like what we are experiencing... |
|
Also similar betamaxteam/betamax#117 |
|
The response from Travis CI support:
My reply was (which contains some info I haven't shared in this thread yet)
That was 2 days ago, no further correspondence since then have taken place. |
|
@cowboygneox sorry to drag you into this again, but do you mind taking a closer look? seems the issue here is similar to some old betamax issues, betamaxteam/betamax#134 and betamaxteam/betamax#117. I think the description "It seems like the Betamax filters aren't installed in the PR build" is accurate, but as to why, I have no clue. Any ideas on what logging could be added our Betamax code, or LittleProxy? |
|
Hmm... betamaxteam/betamax#193 also fails, and so did betamaxteam/betamax#192 until a race condition was fixed. Related? |
|
This branch is also interesting https://github.com/strmer15/betamax/commits/feature/start_once_2 (betamaxteam/betamax#192 is about https://github.com/strmer15/betamax/commits/feature/start_once) |
|
@dentarg It's no fun waking up to an email in the morning that your library is causing others issues :( I'm looking into it right now. |
|
@dentarg Ugh, more SSL issues. These seem to be coming up more frequently now that Java enforces it more. I've actually been struggling myself to get this working (though I have it working) but communicating the steps that I used may be just as challenging. Let me keep looking at your config. |
|
@dentarg (and others observing this): is there any chance you can join the Betamax Gitter so that we can quick round up on this? |
|
@cowboygneox sure, I can join |
|
Latest from Travis CI
My reply
|
|
@dentarg I think I solved your issues in the latest 2.0.0-SNAPSHOT of Betamax. Can you try pulling it and see if it works? |
|
@cowboygneox seems like it stills fails, using https://oss.sonatype.org/content/repositories/snapshots/software/betamax/betamax-junit/2.0.0-SNAPSHOT/betamax-junit-2.0.0-20160415.010203-17.pom, build log at https://travis-ci.org/twingly/twingly-search-api-java/jobs/115858478 Haven't looked into it more than that and I'm afraid I wont be able until some time next week |
|
@dentarg I submitted another SNAPSHOT, and then I also forked your work and ran tests. Your tests passed fine on my run: https://travis-ci.org/cowboygneox/twingly-search-api-java/builds/123307325. Will you kick yours off again? |
|
@dentarg Looks like it failed again. I have absolutely no idea why your branch is failing and mine is consistently passing. All I did was fork your branch and ignore some files. We'll probably have to ask travis-ci to compare. |
|
@dentarg Maybe I need to rebase against master. I'll try that next. |
|
It would be nice to finally get this in, @twingly/dev WDYT of the following: Since the problems we are seeing are likely due to the combination of betamax and https (see #21) we could make the https part configurable for now, defaulting to |
|
@walro I am confident that disabling use of Also, VCR doesn't fire up a proxy server, it just stubs out the http_client you're using underneath. It doesn't do a true MITM proxy like we're trying to do. We're trying to support more HTTP clients than we have in the past, and the (seemingly) most appropriate way is just to fire up another server to hit. |
|
@walro Betamax 2.0 official is out. It fixes this issue, but it will require you to change how you run builds on Travis. Please see the documentation on Betamax's readme and let me know if you have any questions. |
Thanks, on vacation right now. But once back at the office I'll take a look (unless one of my co-workers beats me to it :-)) |
|
I'm also on vacation, but I may take a look at it tonight anyways :-)
|
|
Closed in favour of #26. |
added betamax functional tests