Skip to content

Hotfix/internal event parser#2013

Merged
CodeNinjaEvan merged 3 commits into
developfrom
Hotfix/internalEventParser
Feb 28, 2019
Merged

Hotfix/internal event parser#2013
CodeNinjaEvan merged 3 commits into
developfrom
Hotfix/internalEventParser

Conversation

@BlueHoopor

@BlueHoopor BlueHoopor commented Feb 28, 2019

Copy link
Copy Markdown
Contributor

What does this PR do?

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

What does this PR do?
add supported for Internal Transaction event parser.

Why are these changes required?
The internal-transaction's event's ABI may be different from the Outer Transaction.
Only affect Event Subscription Plugin.

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io

codecov-io commented Feb 28, 2019

Copy link
Copy Markdown

Codecov Report

Merging #2013 into develop will increase coverage by 0.02%.
The diff coverage is 3.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2013      +/-   ##
=============================================
+ Coverage      44.73%   44.75%   +0.02%     
- Complexity      4025     4030       +5     
=============================================
  Files            489      489              
  Lines          28832    28828       -4     
  Branches        3007     3008       +1     
=============================================
+ Hits           12898    12902       +4     
+ Misses         14783    14774       -9     
- Partials        1151     1152       +1
Impacted Files Coverage Δ Complexity Δ
...main/java/org/tron/common/runtime/vm/DataWord.java 67.97% <0%> (ø) 57 <0> (ø) ⬇️
...common/runtime/vm/program/InternalTransaction.java 75% <0%> (ø) 13 <0> (ø) ⬇️
...rg/tron/common/logsfilter/ContractEventParser.java 57.26% <0%> (ø) 24 <0> (ø) ⬇️
...g/tron/common/runtime/vm/LogInfoTriggerParser.java 12.67% <0%> (-0.37%) 3 <0> (ø)
...main/java/org/tron/common/runtime/RuntimeImpl.java 63.47% <25%> (-0.05%) 54 <0> (ø)
src/main/java/org/tron/core/net/node/NodeImpl.java 48.06% <0%> (ø) 83% <0%> (ø) ⬇️
src/main/java/org/tron/core/db/Manager.java 43.01% <0%> (+0.09%) 120% <0%> (+1%) ⬆️
src/main/java/org/tron/core/db/KhaosDatabase.java 63.69% <0%> (+0.63%) 24% <0%> (+1%) ⬆️
.../java/org/tron/core/net/node/NodeDelegateImpl.java 33.55% <0%> (+0.67%) 19% <0%> (+1%) ⬆️
...n/java/org/tron/common/overlay/server/Channel.java 79.43% <0%> (+0.93%) 29% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c138e55...adf8d30. Read the comment docs.

@CodeNinjaEvan CodeNinjaEvan merged commit 042f0dd into develop Feb 28, 2019
@CodeNinjaEvan CodeNinjaEvan mentioned this pull request Feb 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CodeNinjaEvan CodeNinjaEvan CodeNinjaEvan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BlueHoopor @codecov-io @CodeNinjaEvan