Skip to content

fix transaction time stamp#1951

Merged
DorianRust merged 1 commit into
developfrom
Hotfix/changeTimeStamp
Jan 21, 2019
Merged

fix transaction time stamp#1951
DorianRust merged 1 commit into
developfrom
Hotfix/changeTimeStamp

Conversation

@DorianRust

Copy link
Copy Markdown
Contributor

What does this PR do?
change transaction's timestamp from tx.timestamp to block.timestamp.
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io

codecov-io commented Jan 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1951 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1951      +/-   ##
=============================================
- Coverage      44.77%   44.77%   -0.01%     
+ Complexity      4024     4023       -1     
=============================================
  Files            489      489              
  Lines          28731    28731              
  Branches        3030     3030              
=============================================
- Hits           12865    12864       -1     
  Misses         14719    14719              
- Partials        1147     1148       +1
Impacted Files Coverage Δ Complexity Δ
...gsfilter/capsule/TransactionLogTriggerCapsule.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...org/tron/common/overlay/server/ChannelManager.java 66.21% <0%> (-1.36%) 19% <0%> (-1%)
...n/java/org/tron/common/overlay/server/Channel.java 78.5% <0%> (-0.94%) 28% <0%> (-1%)
src/main/java/org/tron/core/net/node/NodeImpl.java 48.18% <0%> (+0.12%) 84% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a22ee...2738349. Read the comment docs.

@DorianRust DorianRust merged commit f619d8d into develop Jan 21, 2019
@shydesky shydesky deleted the Hotfix/changeTimeStamp branch November 13, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants