Skip to content

fix: change setTransferTo_address set field#1943

Merged
DorianRust merged 1 commit into
developfrom
bug_fix/addTransactioninfo
Jan 17, 2019
Merged

fix: change setTransferTo_address set field#1943
DorianRust merged 1 commit into
developfrom
bug_fix/addTransactioninfo

Conversation

@CodeNinjaEvan

@CodeNinjaEvan CodeNinjaEvan commented Jan 17, 2019

Copy link
Copy Markdown
Collaborator

What does this PR do?
TransferTo_address set internalTransaction TransferTo_address.
Why are these changes required?
TransferTo_address set up as ReceiveAddress.
This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io

codecov-io commented Jan 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1943 into develop will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1943      +/-   ##
=============================================
- Coverage      45.35%   45.22%   -0.14%     
+ Complexity      4089     4076      -13     
=============================================
  Files            495      495              
  Lines          28821    28821              
  Branches        3011     3011              
=============================================
- Hits           13073    13033      -40     
- Misses         14594    14644      +50     
+ Partials        1154     1144      -10
Impacted Files Coverage Δ Complexity Δ
...gsfilter/capsule/TransactionLogTriggerCapsule.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...g/tron/core/net/message/ChainInventoryMessage.java 0% <0%> (-66.67%) 0% <0%> (-7%)
...g/tron/core/net/message/BlockInventoryMessage.java 73.91% <0%> (-21.74%) 5% <0%> (-1%)
...g/tron/core/net/message/SyncBlockChainMessage.java 75% <0%> (-18.75%) 4% <0%> (-1%)
...rg/tron/common/net/udp/handler/MessageHandler.java 62.06% <0%> (-10.35%) 5% <0%> (-1%)
...g/tron/common/overlay/discover/DiscoverServer.java 76.27% <0%> (-8.48%) 8% <0%> (-2%)
...in/java/org/tron/core/net/peer/PeerConnection.java 46.29% <0%> (-4.63%) 27% <0%> (-4%)
.../org/tron/core/net/message/TronMessageFactory.java 36% <0%> (-4%) 4% <0%> (-1%)
src/main/java/org/tron/common/utils/ByteArray.java 53.33% <0%> (-3.34%) 15% <0%> (-1%)
...ay/discover/node/statistics/MessageStatistics.java 64.82% <0%> (-2.76%) 19% <0%> (-2%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a706e5c...a0b70dc. Read the comment docs.

@DorianRust DorianRust merged commit c616367 into develop Jan 17, 2019
@DorianRust DorianRust deleted the bug_fix/addTransactioninfo branch January 17, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiangyy0824 jiangyy0824 Awaiting requested review from jiangyy0824
@wubin12 wubin12 Awaiting requested review from wubin12
1 more reviewer
@DorianRust DorianRust DorianRust approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CodeNinjaEvan @codecov-io @DorianRust