Defer numeric input clamping to blur/Enter#59
Merged
Conversation
Numeric inputs were clamping values on every keystroke, making editing unusable. Created NumericInput component that allows free typing and only clamps to min/max on blur, Enter, or Escape. Replaces inline clamping in BinConfigurator SliderRow, BinEditorToolbar label fields, and SettingsPopover bed size input. Added vitest config for path alias resolution. Signed-off-by: Jason Madigan <[email protected]>
Signed-off-by: Jason Madigan <[email protected]>
jasonmadigan
marked this pull request as ready for review
June 3, 2026 15:26
shanetinklenberg
pushed a commit
to shanetinklenberg/tracefinity
that referenced
this pull request
Jun 28, 2026
* Defer numeric input validation to blur/Enter (tracefinity#55) Numeric inputs were clamping values on every keystroke, making editing unusable. Created NumericInput component that allows free typing and only clamps to min/max on blur, Enter, or Escape. Replaces inline clamping in BinConfigurator SliderRow, BinEditorToolbar label fields, and SettingsPopover bed size input. Added vitest config for path alias resolution. Signed-off-by: Jason Madigan <[email protected]> * fix: default step to 1, export clamping logic for testability Signed-off-by: Jason Madigan <[email protected]> --------- Signed-off-by: Jason Madigan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes numeric input validation firing on every keystroke, making fields unusable. Extracts a shared
NumericInputcomponent that allows free typing and only clamps to min/max on blur or Enter.Closes #55
Changes
NumericInputcomponent with deferred clamping logicBinConfigurator,BinEditorToolbar,SettingsPopoverclampNumericValueas a pure function for testabilityTest plan
NumericInput.test.ts) covering clamping, parsing, edge casesnumeric-input.spec.ts) covering free typing, blur clamp, Enter clamp, empty reverttsc --noEmitclean