Skip to content

Defer numeric input clamping until commit#57

Closed
noobydp wants to merge 5 commits into
tracefinity:mainfrom
noobydp:codex/issue-55-numeric-fields
Closed

Defer numeric input clamping until commit#57
noobydp wants to merge 5 commits into
tracefinity:mainfrom
noobydp:codex/issue-55-numeric-fields

Conversation

@noobydp

@noobydp noobydp commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a shared NumericInput component that preserves draft text while a field is focused
  • commit numeric edits on blur or Enter, clamp only at commit time, and let Escape revert without applying the draft
  • use the shared input for bin configuration sliders, bed size settings, and text label size/depth controls

Validation

  • npm exec vitest run src/components/BinConfigurator.test.ts src/components/NumericInput.test.ts
  • npm run build
  • git diff --check

Code and PR drafted with Codex

@noobydp
noobydp force-pushed the codex/issue-55-numeric-fields branch from 2c0d71f to 47d6e4e Compare June 3, 2026 08:07
@noobydp

noobydp commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

No longer required, resolved by #59

@noobydp noobydp closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant